Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[task] Update to go-1.21 #324

Closed
wants to merge 2 commits into from
Closed

[task] Update to go-1.21 #324

wants to merge 2 commits into from

Conversation

sananand007
Copy link
Collaborator

Description

Clearly describe changes in your PR, new feature or bug fixes.

Solution

  • Describe your code changes in detail for reviewers as well as documentation purposes.
  • For bug fixes, explain the solutions and how they fix the issues.
  • For new features, describe the high-level ideas.

Testing

  • Integration testing on Heroku staging
  • Added new unit tests

Checks

  • Have you removed commented code?
  • Have you used gofmt to format your code?

timwangmusic
timwangmusic requested changes Sep 30, 2023
View reviewed changes
Copy link
Owner

@timwangmusic timwangmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change the module name

@sananand007
Copy link
Collaborator Author

its auto @timwangmusic , may be the update sees that is the correct way ?

@timwangmusic
Copy link
Owner

its auto @timwangmusic , may be the update sees that is the correct way ?

Can you run to mod tidy?

@sananand007
Copy link
Collaborator Author

@timwangmusic go mod tidy does not change anything, exactly the same

@sananand007 sananand007 deleted the u/sandeep/update_go_1p21 branch October 22, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwangmusic timwangmusic timwangmusic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sananand007 @timwangmusic