Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image location for location input with two parts #395

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

timwangmusic
Copy link
Owner

@timwangmusic timwangmusic commented Dec 30, 2024

Description

When users use locations with only city followed by country (e.g. Paris, France), the image is stored under / with the current implementation. In this fix, the images will be stored in country/cities/city_name directory in the S3 bucket.

Solution

  • Add a simple validation in the image fetcher.
  • Add a fixed filler for location inputs without admin area one.

Testing

  • Integration testing on Heroku staging
  • Added new unit tests

Checks

  • Have you removed commented code?
  • Have you used gofmt to format your code?

Copy link
Collaborator

@sananand007 sananand007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@timwangmusic timwangmusic merged commit b888a55 into master Dec 31, 2024
4 checks passed
@timwangmusic timwangmusic deleted the fix-gen-img-location branch December 31, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants