Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Detail how to override the default upload media types #1925

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

Jord-Gui
Copy link
Contributor

@Jord-Gui Jord-Gui commented Jul 19, 2024

General Contributing:

https://github.com/tinacms/tina-cloud/issues/2078

All New Content Submissions: (To be confirmed by reviewer)

  • Title is short & specific
  • Headers are logically ordered & consistent
  • Purpose of document is explained in the first paragraph
  • Procedures are tested and work
  • Any technical concepts are explained or linked to
  • Document follows structure from templates
  • All links work
  • The spelling and grammar checker has been run
  • Graphics and images are clear and useful
  • Any prerequisites and next steps are defined.
image

Figure: The default accepted file types

image

Figure: Added property

@Jord-Gui Jord-Gui requested a review from a team as a code owner July 19, 2024 06:33
Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ❌ Failed (Inspect) Jul 29, 2024 6:31am

Co-authored-by: Kelly Davis <kldavis4@users.noreply.github.com>
@JackDevAU
Copy link
Member

Are there any types that a user could upload that aren't supported on Tina Cloud?
Should we add a point that not all types are allowed as Tina Cloud only allows certain files?

@joshbermanssw
Copy link
Contributor

Are there any types that a user could upload that aren't supported on Tina Cloud? Should we add a point that not all types are allowed as Tina Cloud only allows certain files?

@JackDevAU good idea, similar issue we ran into with tina.io and some file types disallowed by Tina Cloud

@Jord-Gui
Copy link
Contributor Author

Jord-Gui commented Jul 25, 2024

Are there any types that a user could upload that aren't supported on Tina Cloud? Should we add a point that not all types are allowed as Tina Cloud only allows certain files?

Cc: @joshbermanssw @JackDevAU

As per tinacms/tinacms#4677 (comment), what we thought was a Tina Cloud issue was actually Tina.io using Cloudinary.

Repo based media should accept everything Cloudinary does as it is stored in GitHub.

image

Figure: Video and word docs uploaded to Tina Cloud via Media Manager

@Jord-Gui Jord-Gui requested a review from JackDevAU July 25, 2024 01:52
@Jord-Gui Jord-Gui enabled auto-merge (squash) July 25, 2024 01:54
@JackDevAU
Copy link
Member

Hey @Jord-Gui
Should we add in a column for what the default fields are? or is everything in the table part of the defaults and aren't needed to be added into the accept field?

@Jord-Gui
Copy link
Contributor Author

Jord-Gui commented Jul 28, 2024

Hey @Jord-Gui Should we add in a column for what the default fields are? or is everything in the table part of the defaults and aren't needed to be added into the accept field?

@JackDevAU Yeah so everything in that table is supported by default and if you want to override that, then you use the accept property e.g. if you want to limit it to only video/mp4's.

Jord-Gui and others added 2 commits July 29, 2024 16:28
Co-authored-by: Jack Pettit [SSW] <57518417+JackDevAU@users.noreply.github.com>
Co-authored-by: Jack Pettit [SSW] <57518417+JackDevAU@users.noreply.github.com>
@Jord-Gui Jord-Gui merged commit 0ed2d1d into main Jul 29, 2024
2 of 4 checks passed
@Jord-Gui Jord-Gui deleted the upload-non-image-files branch July 29, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants