Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Docs Rich Text – Updating and Seperating out Rich-Text Field Type Page Content #2187

Merged
merged 20 commits into from
Sep 17, 2024
Merged

📝 Docs Rich Text – Updating and Seperating out Rich-Text Field Type Page Content #2187

merged 20 commits into from
Sep 17, 2024

Conversation

tina-cloud-app[bot]
Copy link
Contributor

@tina-cloud-app tina-cloud-app bot commented Sep 12, 2024 •
edited by isaaclombardssw
Loading

Closes #1964

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 11:50pm

@isaaclombardssw isaaclombardssw self-assigned this Sep 12, 2024
@isaaclombardssw isaaclombardssw changed the title rich text-document-update (PR from TinaCMS) 📝 Docs Rich Text – Updating and Seperating out Rich-Text Field Type Page Content Sep 12, 2024
@isaaclombardssw isaaclombardssw marked this pull request as ready for review September 17, 2024 05:27
@isaaclombardssw isaaclombardssw requested a review from a team as a code owner September 17, 2024 05:27
bradystroud
bradystroud approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is a big improvement, but the page is still really big!

content/docs/reference/rich-text-usage/.gitkeep.mdx Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file to delete?

content/docs/reference/rich-text-usage/markdown-shortcode.mdx Outdated

## Known Issues

Please see the related [GitHub discussion](https://github.com/tinacms/tinacms/discussions/4794) to suggest improvements to this feature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to top with warning

content/docs/reference/rich-text-usage/markdown-tables.mdx Outdated

The table can only be saved if added with cell data immediately after creation, before leaving the CMS subwindow. This issue only occurs on initial creation of the table.

For further development work on Markdown Tables, engage with the related [GitHub issue](https://github.com/tinacms/tinacms/discussions/4793) or [contribute](https://github.com/tinacms/tinacms).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to top with warning

@isaaclombardssw isaaclombardssw merged commit 5a745f9 into main Sep 17, 2024
4 checks passed
@isaaclombardssw isaaclombardssw deleted the tina/rich-text-document-update branch September 17, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbermanssw joshbermanssw joshbermanssw left review comments

@bradystroud bradystroud bradystroud approved these changes

Assignees

@isaaclombardssw isaaclombardssw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📝 Docs – Rich Text Field – Improvements
3 participants
@bradystroud @joshbermanssw @isaaclombardssw