Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ” Logo Grid – Moving to internal links + removing https validation on the link field #2222

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

isaaclombardssw
Copy link
Contributor

@isaaclombardssw isaaclombardssw commented Sep 18, 2024

Content has been updated to use internal links rather than external ones routing back to tina.io.

Validation was removed to allow this.

Description was added for content editor UX.

Closes #1836

General Contributing:

All New Content Submissions: (To be confirmed by reviewer)

  • Title is short & specific
  • Headers are logically ordered & consistent
  • Purpose of document is explained in the first paragraph
  • Procedures are tested and work
  • Any technical concepts are explained or linked to
  • Document follows structure from templates
  • All links work
  • The spelling and grammar checker has been run
  • Graphics and images are clear and useful
  • Any prerequisites and next steps are defined.

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
tina-io βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 20, 2024 2:23am

Copy link
Collaborator

@joshbermanssw joshbermanssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isaaclombardssw
Copy link
Contributor Author

isaaclombardssw commented Sep 18, 2024

Note: after testing, nothing has changed form the live site, but some of the links don't work as expected (just take you to the showcase page, despite having a fragment, since the showcase for that company doesn't exist) – we could update the showcase companies OR remove fragments from the links that have no showcase (just go the showcase page).

@isaaclombardssw isaaclombardssw merged commit b66adea into main Sep 20, 2024
4 checks passed
@isaaclombardssw isaaclombardssw deleted the logo-grid-relative-links branch September 20, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ’Έ Tech Debt - Internal Linking from Logo template
2 participants