Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔍 Logo Grid – Moving to internal links + removing https validation on the link field #2222

Merged
merged 2 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions components/blocks/LogoGrid.template.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,7 @@ export const logoGridTemplate: TinaTemplate = {
name: 'link',
label: 'Link',
type: 'string',
ui: {
validate: (val) => {
// make sure value is https url
if (!val?.startsWith('https://')) {
return 'Must be a valid https url'
}
},
},
description: 'The URL to link to when the logo is clicked. Should be either (1) an internal link (e.g. /showcase#unity) or (2) an external link (e.g. https://ndcconferences.com/).',
},
{ name: 'logo', label: 'Logo Image', type: 'image' },
{ name: 'size', label: 'Size', type: 'number' },
Expand Down
28 changes: 14 additions & 14 deletions content/blocksPages/home.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,49 +39,49 @@
"items": [
{
"name": "Bunny Net",
"link": "https://tina.io/showcase#bunny-net",
"link": "/showcase#bunny-net",
"logo": "/svg/logos/bunnynet.svg",
"size": 220
},
{
"name": "Unity",
"link": "https://tina.io/showcase#unity",
"link": "/showcase#unity",
"logo": "/svg/logos/unity.svg",
"size": 220
},
{
"name": "Protocol Labs",
"link": "https://tina.io/showcase#protocol-labs",
"link": "/showcase#protocol-labs",
"logo": "/svg/logos/protocollabs.svg",
"size": 90
},
{
"name": "City of London",
"link": "https://tina.io/showcase#city-of-london",
"link": "/showcase#city-of-london",
"logo": "/svg/logos/cityoflondon.svg",
"size": 120
},
{
"name": "Devolver Digital",
"link": "https://tina.io/showcase#devolver-digital",
"link": "/showcase#devolver-digital",
"logo": "/svg/logos/devolverdigital.svg",
"size": 150
},
{
"name": "Smashing Magazine",
"link": "https://tina.io/showcase#smashing-magazine",
"link": "/showcase#smashing-magazine",
"logo": "/svg/logos/smashing.svg",
"size": 90
},
{
"name": "Supernova",
"link": "https://tina.io/showcase#supernova",
"link": "/showcase#supernova",
"logo": "/svg/logos/supernova.svg",
"size": 240
},
{
"name": "Paradise Helicopters",
"link": "https://tina.io/showcase#paradise-helicopters",
"link": "/showcase#paradise-helicopters",
"logo": "/svg/logos/paradisehelicopters.svg",
"size": 150
},
Expand All @@ -93,37 +93,37 @@
},
{
"name": "SSW",
"link": "https://tina.io/showcase#ssw",
"link": "/showcase#ssw",
"logo": "/svg/logos/ssw-logo-charcoal.svg",
"size": 150
},
{
"name": "Comedia",
"link": "https://tina.io/showcase#comedia",
"link": "/showcase#comedia",
"logo": "/svg/logos/comedia.svg",
"size": 110
},
{
"name": "RRE Ventures",
"link": "https://tina.io/showcase#rre-ventures",
"link": "/showcase#rre-ventures",
"logo": "/svg/logos/rreventures.svg",
"size": 220
},
{
"name": "Shadow Lion",
"link": "https://tina.io/showcase#shadow-lion",
"link": "/showcase#shadow-lion",
"logo": "/svg/logos/shadowlion.svg",
"size": 220
},
{
"name": "Roev",
"link": "https://tina.io/showcase#roev",
"link": "/showcase#roev",
"logo": "/svg/logos/roe.svg",
"size": 200
},
{
"name": "Locality Bank",
"link": "https://tina.io/showcase#locality-bank",
"link": "/showcase#locality-bank",
"logo": "/svg/logos/localitybank.svg",
"size": 200
}
Expand Down
2 changes: 1 addition & 1 deletion tina/tina-lock.json

Large diffs are not rendered by default.

Loading