🐛 Nightmare Bug – Scroll Event Listening Offset Calculation Bug

[isaaclombardssw]

Related to and closes #2211.

To test the fix, please go the vercel, then Docs | Introduction to TinaCMS.

Previously...

• Page scroll position versus headings calculated in pixels from the DOM with element.offsetTop and window.scrollY, compared to some magic number.
• These two variables in some cases diverging min/max values depending on screen sizes, so the comparison stops being an accurate position of location on the page.

Updated impl...

• Scroll position and headings in comparison are both totally relative (scroll pos vs maximum scroll pos, and heading pos vs maximum content height).
• No magic numbers.

### General Contributing:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

All New Content Submissions: (To be confirmed by reviewer)

• Title is short & specific
• Headers are logically ordered & consistent
• Purpose of document is explained in the first paragraph
• Procedures are tested and work
• Any technical concepts are explained or linked to
• Document follows structure from templates
• All links work
• The spelling and grammar checker has been run
• Graphics and images are clear and useful
• Any prerequisites and next steps are defined.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tina-io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 20, 2024 1:38am

[bradystroud]

2 quick suggestions