Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Detect multiple sources correctly #101

Open
alexfernandez opened this issue Oct 21, 2024 · 0 comments · May be fixed by #102
Open

[Bug] Detect multiple sources correctly #101

alexfernandez opened this issue Oct 21, 2024 · 0 comments · May be fixed by #102
Assignees
Labels
bug Something isn't working triage Triage

Comments

@alexfernandez
Copy link

Module

Tinybird Data Project

Describe the Bug

  • Detection of sources in analytics_sources.pipe is done using the current domain from the first event that arrives. This works fine on setups where there is only a single source, but when there are many it can lead to false positives: the current domain may change from event to event.

Expected Behavior

When multiple events arrive together they should be processed using the current domain from each one.

To Reproduce

Send multiple events with different href and referrer. The current domain from the first event is used for all of them.

Details

This behavior is particularly problematic with the Tinybird gatherer, as it coalesces multiple events and sends them together. It also leads to memory issues in certain setups with billions of events.

@alexfernandez alexfernandez added bug Something isn't working triage Triage labels Oct 21, 2024
@alexfernandez alexfernandez linked a pull request Oct 21, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants