Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade boxroot, prepare OCaml 5 support #59

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Remove call to `caml_c_thread_unregister`, breaks in OCaml 5

f9b6847
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Upgrade boxroot, prepare OCaml 5 support #59

Remove call to `caml_c_thread_unregister`, breaks in OCaml 5
f9b6847
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jan 28, 2024 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.77.0-nightly (6b4f1c5e7 2024-01-27)
  • cargo 1.77.0-nightly (7bb7b5395 2024-01-20)
  • clippy 0.1.77 (6b4f1c5 2024-01-27)

Annotations

Check warning on line 122 in src/runtime.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `caml_c_thread_unregister` is never used

warning: function `caml_c_thread_unregister` is never used
   --> src/runtime.rs:122:12
    |
122 |     pub fn caml_c_thread_unregister() -> isize;
    |            ^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 56 in src/runtime.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

mutable reference of mutable static is discouraged

warning: mutable reference of mutable static is discouraged
  --> src/runtime.rs:56:9
   |
56 |         &mut RUNTIME
   |         ^^^^^^^^^^^^ mutable reference of mutable static
   |
   = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
   = note: reference of mutable static is a hard error from 2024 edition
   = note: mutable statics can be written to by multiple threads: aliasing violations or data races will cause undefined behavior
   = note: `#[warn(static_mut_ref)]` on by default
help: mutable references are dangerous since if there's any other pointer or reference used for that static while the reference lives, that's UB; use `addr_of_mut!` instead to create a raw pointer
   |
56 |         addr_of_mut!(RUNTIME)
   |

Check warning on line 15 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `local_roots as ocaml_sys_local_roots`, `set_local_roots as ocaml_sys_set_local_roots`

warning: unused imports: `local_roots as ocaml_sys_local_roots`, `set_local_roots as ocaml_sys_set_local_roots`
  --> src/memory.rs:15:17
   |
15 |     caml_alloc, local_roots as ocaml_sys_local_roots, set_local_roots as ocaml_sys_set_local_roots,
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default