Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming server support? #20

Closed
kevintanhongann opened this issue Feb 23, 2024 · 6 comments · Fixed by #43
Closed

streaming server support? #20

kevintanhongann opened this issue Feb 23, 2024 · 6 comments · Fixed by #43

Comments

@kevintanhongann
Copy link

Is there a way to run and expose an API streaming server compatible with OpenAI API specifications?

@tjake
Copy link
Owner

tjake commented Feb 23, 2024

Probably, here's the current API call for chat

https://github.com/tjake/Jlama/blob/main/jlama-cli/src/main/java/com/github/tjake/jlama/cli/serve/GenerateResource.java

@phact
Copy link
Contributor

phact commented Feb 23, 2024

I want this feature too

@geoand
Copy link
Contributor

geoand commented Mar 1, 2024

I am pretty sure that this would (at least) require Generator#generate to be enhanced with a callback that is called when the generation is complete.

@phact
Copy link
Contributor

phact commented Mar 7, 2024

You mean for stream=false?

@geoand
Copy link
Contributor

geoand commented Mar 7, 2024

For both :)

@phact
Copy link
Contributor

phact commented Mar 7, 2024

working PR here #23

@tjake tjake linked a pull request Aug 9, 2024 that will close this issue
@tjake tjake closed this as completed in #43 Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants