Support the s (dotAll) flag

tjenkinson · Oct 29, 2023 · ecad135 · ecad135
1 parent c319095
commit ecad135
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -46,7 +46,7 @@
     "lint-staged": "15.0.2",
     "micromatch": "4.0.5",
     "prettier": "3.0.3",
-    "redos-detector": "4.2.0",
+    "redos-detector": "4.3.0",
     "rollup": "4.1.4",
     "ts-jest": "29.1.1",
     "tslib": "2.6.2",

diff --git a/src/eslint-plugin-redos-detector.test.ts b/src/eslint-plugin-redos-detector.test.ts
@@ -1,7 +1,7 @@
 import { rules } from './eslint-plugin-redos-detector';
 import { RuleTester } from 'eslint';
 
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } });
+const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 'latest' } });
 
 describe('Eslint Plugin Redos Detector', () => {
   describe(`'no-unsafe-regex' rule`, () => {
@@ -20,6 +20,10 @@ describe('Eslint Plugin Redos Detector', () => {
             code: '/a/u',
             options: [{ ignoreError }],
           },
+          {
+            code: '/a/s',
+            options: [{ ignoreError }],
+          },
           ...(ignoreError
             ? [
                 {

diff --git a/src/eslint-plugin-redos-detector.ts b/src/eslint-plugin-redos-detector.ts
@@ -59,12 +59,15 @@ export const rules: Record<string, Rule.RuleModule> = {
 
           let caseInsensitive = false;
           let unicode = false;
+          let dotAll = false;
 
           for (const flag of flags.split('')) {
             if (flag === 'i') {
               caseInsensitive = true;
             } else if (flag === 'u') {
               unicode = true;
+            } else if (flag === 's') {
+              dotAll = true;
             } else if (flag !== 'g') {
               if (!ignoreError) {
                 context.report({
@@ -94,6 +97,7 @@ export const rules: Record<string, Rule.RuleModule> = {
               timeout,
               caseInsensitive,
               unicode,
+              dotAll,
             });
           } catch (e: any) {
             if (!ignoreError) {