Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More efficient camera feed parsing #5

Open
tjhorner opened this issue Sep 6, 2017 · 1 comment
Open

More efficient camera feed parsing #5

tjhorner opened this issue Sep 6, 2017 · 1 comment
Assignees
@tjhorner
Labels
enhancement

Comments

@tjhorner
Copy link
Owner

tjhorner commented Sep 6, 2017

The way binary data (and thus camera frames) are parsed is very hacky, uses some weird methods to parse JSON that might have been in the packet, etc. It's really experimental at the moment, and it should definitely be reworked to be more efficient.

Also, it will strictly only work for JPEGs at the moment, which is not ideal.
@tjhorner tjhorner self-assigned this Sep 6, 2017
@tjhorner tjhorner mentioned this issue Sep 6, 2017
Closed
@tjhorner
Copy link
Owner Author

tjhorner commented Sep 7, 2017

Rewriting the JSON-RPC client as a state machine seems to be the best choice for doing this.

MakerBot's own C++ JSON-RPC client might be of help to create this.

@tjhorner tjhorner mentioned this issue Sep 7, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjhorner tjhorner

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tjhorner