Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog transition not working correctly #341

Open
jaroslavnemec opened this issue Dec 29, 2024 · 0 comments
Open

Dialog transition not working correctly #341

jaroslavnemec opened this issue Dec 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jaroslavnemec
Copy link

Describe the bug.
On dialog open, transition animation is applied only to #ui-dialog, but not to #ui-overlay.
On dialog close, transition animation is applied only to #ui-overlay, but not to #ui-dialog.

Easy workaround by adding css works only for opening animation. For close the position of #ui-dialog is removed from element which makes it worse.

To Reproduce:
Create passage with dialog:

<<link TestDialog>>
<<run Dialog
	.create("TestDialog")
	.append("TestDialog TestDialog")
	.open();>>
<</link>>

test open, close dialog through the link

Expected behavior.
Smooth transition for both #ui-overlay and #ui-dialog when opening and closing

Project details.

  • SugarCube Version: 2.37.3
  • Included Add-ons: none
  • Included Libraries: none
  • Compiler & Version: both Twine web version and Tweego 2.1.1

Desktop details.

  • OS & Version: [e.g., Windows 10]
  • Browser & Version: Vivaldi 6.0.2979.18, MS edge, does not matter
@jaroslavnemec jaroslavnemec added the bug Something isn't working label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant