Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape bindings dir #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

baodrate
Copy link

Currently, the bind-key commands fail if BINDINGS_DIR (via TPM's installation path) contains characters that need to be escaped in sh-syntax. The most obvious example is spaces.

e.g. TMUX_PLUGIN_MANAGER_PATH=/Users/foobar/Library/Application Support/tmux/plugins causes install_key to be bound to sh -c /Users/foobar/Library/Application Support/tmux/plugins/tpm/bindings/install_plugins which is interpreted as the command /Users/foobar/Library/Application with a single argument of Support/tmux/plugins/tpm/bindings/install_plugins.

This PR fixes this by using tmux's built-in sh-escaping (the #{q:...} format string syntax). This requires a new tmux environment variable.

@baodrate
Copy link
Author

Also fixed sh word splitting breaking silently_source_all_tmux_files in scripts/source_plugins.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant