Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete images #153

Merged
merged 13 commits into from
Oct 24, 2023
Merged

Delete images #153

merged 13 commits into from
Oct 24, 2023

Conversation

oliverroick
Copy link
Contributor

Contributes towards tnc-ca-geo/animl-api#89

  • Adds new button to the image toolbar and context menu to delete images
  • Adds stubs for actions and reducer required to delete images

NOTE: The API for image delete needs to be wired up once it is implemented

@oliverroick oliverroick marked this pull request as ready for review September 28, 2023 02:17
src/api/buildQuery.js Outdated Show resolved Hide resolved
src/features/loupe/FullSizeImage.jsx Show resolved Hide resolved
src/features/review/reviewSlice.js Show resolved Hide resolved
Copy link
Member

@nathanielrindlaub nathanielrindlaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just a few open question and final requests.

src/features/images/imagesSlice.js Show resolved Hide resolved
@@ -17,6 +17,11 @@ const initialState = {
isLoading: false,
operation: null, /* 'fetching', 'updating', 'deleting' */
errors: null,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed now?

@nathanielrindlaub nathanielrindlaub merged commit 8e7fb8c into main Oct 24, 2023
@nathanielrindlaub nathanielrindlaub deleted the delete-images branch October 24, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants