chore: rename createEvaluation func

tnkshuuhei · Oct 10, 2024 · 74f65b6 · 74f65b6
1 parent 2578313
commit 74f65b6
Showing 1 changed file with 5 additions and 13 deletions.
diff --git a/src/CEP.sol b/src/CEP.sol
@@ -93,7 +93,7 @@ contract CEP is Initializable, OwnableUpgradeable, AccessControlUpgradeable, Ree
         schemaUID = _schemaUID;
     }
 
-    function createEvaluationPool(
+    function createEvaluationWithPool(
         bytes32 _profileId,
         address _token,
         uint256 _amount,
@@ -103,11 +103,13 @@ contract CEP is Initializable, OwnableUpgradeable, AccessControlUpgradeable, Ree
         external
     {
         (uint256 poolId, Evaluation evaluation) =
-            _createEvaluationPool(_profileId, _token, _amount, _metadata, _contributors);
+            _createEvaluationWithPool(_profileId, _token, _amount, _metadata, _contributors);
         emit EvaluationCreated(poolId, address(evaluation));
     }
 
-    function _createEvaluationPool(
+    /// @dev deploy a new evaluation contract with create2 and initialize it
+    /// @dev create a new evaluation pool struct and store it in the evaluations mapping
+    function _createEvaluationWithPool(
         bytes32 _profileId,
         address _token,
         uint256 _amount,
@@ -157,16 +159,6 @@ contract CEP is Initializable, OwnableUpgradeable, AccessControlUpgradeable, Ree
         return (poolId, evaluation);
     }
 
-    function createEvaluation(
-        bytes32 _profileId,
-        address[] memory _contributors
-    )
-        external
-        returns (Evaluation evaluationAddress)
-    {
-        return _createEvaluation(_profileId, _contributors);
-    }
-
     function _createEvaluation(
         bytes32 _profileId,
         address[] memory _contributors