Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Pick Visible Context for Use With “when” Clauses #32

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

harrylavell
Copy link
Contributor

Summary

  • Add setQuickPickContext(bool) to toggle context on (true) and off (false).
  • Calls setQuickPickContext(bool) during Quick Pick create and onDidHide().

Why did I add this?
I prefer to use 'j' and 'k' without modifiers for navigating through my Harpoon Quick Pick list. This behaviour is similar to how the Neovim plugin works. I wasn't able to find the correct combination of VS Code native contexts for my "when" clause to replicate this behaviour, so I thought to just add it.

Let me know if this PR needs any attention. I'd really like to get this through.

Copy link
Owner

@tobias-z tobias-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a great idea, I like it!
Thank you for contributing 😄

src/commands/editor-quick-pick.ts Outdated Show resolved Hide resolved
@harrylavell
Copy link
Contributor Author

Thank you for the feedback. I look forward to contributing to this project in future.

@harrylavell harrylavell requested a review from tobias-z November 3, 2023 03:54
Copy link
Owner

@tobias-z tobias-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait, I have quite a bit of things to do at work and other things related to studies.

@tobias-z tobias-z merged commit abf49cb into tobias-z:dev Nov 3, 2023
2 checks passed
@harrylavell harrylavell deleted the pr/quick-pick-context branch November 4, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants