Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding proxies optional argument #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Varin6
Copy link

@Varin6 Varin6 commented Sep 11, 2022

I needed to use proxies for requests and added an optional argument to pass in when initializing RightmoveData.

If you don't want to use proxies - nothing changes, if you do, the init looks like this:

rm = RightmoveData(url, False, proxies)

where proxies are a dict:


proxies = { 'https' : 'https://user:password@proxyip:port' } 

@toby-p
Copy link
Owner

toby-p commented Apr 4, 2023

Apologies for the delay! I'm not clear on why this is necessary so hesitant to just implement it. Could you explain why/when it's needed? Would it be better to just allow any kwargs for request.get?

Also please clarify if it also needs to be added to this line:
status_code, content = self._request(weblink)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants