Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedding models handler #1

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Embedding models handler #1

merged 6 commits into from
Sep 13, 2024

Conversation

ranjan-stha
Copy link
Collaborator

Changes

  • Embedding models module added
  • FastAPI wrapper added

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)

@ranjan-stha ranjan-stha requested review from thenav56 and sudan45 and removed request for thenav56 and sudan45 September 12, 2024 08:51
thenav56
thenav56 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a CD to push to GitHub docker registry. Then we can use this with our chatbot backend

@udaynwa udaynwa merged commit b7c5e23 into develop Sep 13, 2024
2 checks passed
@udaynwa udaynwa deleted the feat/embed-model branch September 13, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudan45 sudan45 sudan45 approved these changes

@thenav56 thenav56 thenav56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ranjan-stha @thenav56 @sudan45 @udaynwa