Add tests and publish actions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floitsch
approved these changes
Jan 14, 2024
.github/workflows/ci.yml
Outdated
| if: runner.os == 'Linux' | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install ninja-build |
There was a problem hiding this comment.
Since you don't need to build executables, I would avoid the ninja-part.
See https://github.com/toitlang/pkg-fs.
| (cd build && ninja install-pkgs) | ||
|
|
||
| .PHONY: test | ||
| test: install-pkgs rebuild-cmake |
There was a problem hiding this comment.
See pkg-fs for how to write this without ninja.
tests/CMakeLists.txt
Outdated
|
|
||
| add_custom_target( | ||
| check | ||
| COMMAND ${CMAKE_CTEST_COMMAND} -j${NUM_CPU} -T test --output-on-failure |
There was a problem hiding this comment.
See pkg-fs for how to do this without ninja.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.