Don't accept strings with '\0' for C operations. #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
reviewed
Oct 25, 2024
src/primitive_core.cc
Outdated
| ARGS(Blob, message, bool, add_newline); | ||
| auto bytes = message.address(); | ||
| for (int i = 0; i < message.length(); i++) { | ||
| putchar(bytes[i]); |
There was a problem hiding this comment.
How is this stderr? This looks like a pretty significant regression.
I'd take something like my suggestion above and maybe put it in a static helper function parameterized with the stream.
Also, consider making both member variables of Blob const like:
private:
const uint8* const address_;
const word length_;
There was a problem hiding this comment.
Good catch...
I will update the blob fields in a separate PR.
Co-authored-by: Kasper Lund <kasper@toit.io>
|
Good feedback. |
kasperl
reviewed
Oct 25, 2024
src/primitive_core.cc
Outdated
| fprintf(stderr, "%s%s", message, add_newline ? "\n" : ""); | ||
| fflush(stderr); | ||
| ARGS(Blob, message, bool, add_newline); | ||
| write_to(stderr, message.address(), message.length()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.