chore: small fix for platform config usage #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Razinsky
approved these changes
Jul 4, 2024
|
amzn/style-dictionary#1266 raised this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes some sloppiness I introduced here: #290
I wouldn't mind encapsulating platform config options inside an
optionsproperty like we do for format-level options, it would be a bit more consistent.. But currently style-dictionary also doesn't do this for the platform config option "basePxFontSize" so doing it now would be inconsistent as well.I think we should pull transform options passed through platform config into an "options" object though in the future but this would a small breaking change, so it will be style-dictionary v5. too bad I missed this for v4.