Added Oracle support #67
Conversation
|
I've just discovered that keenborder786 has already submitted his PR on this. Great work! |
| @@ -174,6 +177,8 @@ def conn_string(self): | |||
| else "", | |||
| ) | |||
| ) | |||
| elif self.source_type == "oracle": | |||
| conn_string = f"oracle+cx_oracle://{self.username}:{self.password}@{self.uri}:{self.port}/{self.service_name}" | |||
There was a problem hiding this comment.
I am not familiar with Oracle. Is service_name the equivalent of a database within oracle? Postgres has a similar concept.
There was a problem hiding this comment.
Oracle's Service Name is a way to point to a database (or databases) in the Oracle DB (like DNS), and the Postgres database is the actual database within the Postgres DB.
There was a problem hiding this comment.
@vrajat I am sorry to push, but we're currently using piicatcher as a stage in our pipeline. It would be great for us to have an Oracle support merged -- if there's anything more i can do to improve this PR?
There was a problem hiding this comment.
Sorry for the delay. I'll look into this today.
|
dbcat@0.15.0 has been published to PyPI including Oracle source support: |
api.add_oracle_sourcemodels.CatSourceandCatSource.service_name+ migrationdb.DbScanner._create_oracle_extractorPipeline on my fork: