Possible extractor regression #583

kellytk · 2021-12-02T18:53:52Z

kellytk
Dec 2, 2021

Using ServeFile from tower-http, with a simple app:

let app = Router::new()
    .route("/file.txt", get(file_handler))
    .layer(AddExtensionLayer::new(Arc::new(State {})));

and handler signature:

async fn file_handler (
    request: Request<Body>,
    shared: extract::Extension<Arc<State>>,
) -> Result<Response<ServeFileSystemResponseBody>, (StatusCode, String)>

requests return an "Extensions taken by other extractor" 500 internal server error. However, if I transpose the request and shared parameters, the request is fulfilled as expected. IIRC it worked with either order until recently.

Answered by davidpdrsn

Dec 2, 2021

I just tested and it didn't work on 0.3.x and its never supposed to work so everything is normal.

It isn't supported because Request<Body> used an extractors cannot be combined with other unless Request<Body> is the very last extractor. More details here. Note this links to version 0.3.4 but this behavior has not changed in 0.4.

View full answer

davidpdrsn · 2021-12-02T19:30:32Z

davidpdrsn
Dec 2, 2021
Collaborator

I just tested and it didn't work on 0.3.x and its never supposed to work so everything is normal.

It isn't supported because Request<Body> used an extractors cannot be combined with other unless Request<Body> is the very last extractor. More details here. Note this links to version 0.3.4 but this behavior has not changed in 0.4.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Possible extractor regression #583

{{title}}

Replies: 1 comment

{{title}}

Select a reply

Possible extractor regression #583

kellytk Dec 2, 2021

Replies: 1 comment

davidpdrsn Dec 2, 2021 Collaborator

kellytk
Dec 2, 2021

davidpdrsn
Dec 2, 2021
Collaborator