Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in TLS Support 🎯 #2494

Closed
1 task done
NiiightmareXD opened this issue Jan 7, 2024 · 1 comment
Closed
1 task done

Built-in TLS Support 🎯 #2494

NiiightmareXD opened this issue Jan 7, 2024 · 1 comment

Comments

@NiiightmareXD
Copy link

NiiightmareXD commented Jan 7, 2024

  • I have looked for existing issues (including closed) about this

Feature Request

I think it would be better if Axum had built-in TLS support right now we can use low-level-rustls but it's unnecessarily hard I think it would be better if we had something like in (Actix)[https://actix.rs/docs/http2] which has bind_openssl function and doesn't need any other crates other than OpenSSL and Actix itself.

I can attempt to implement it myself if you believe it would be beneficial.

Motivation

Pretty much every web server uses TLS.

Proposal

The implementation should be easy it has been already done in (axum-server)[https://github.com/programatik29/axum-server] but it would be better if we didn't need to add another crate to project just to get TLS.

Alternatives

using axum-server, low-level-openssl, low-level-rustls and tls-rustls.

@davidpdrsn
Copy link
Member

axum intentionally doesn’t have that built-in and I think I want it to stay that way.

In the future axum::serve will be generic over the listener and IO which will make it easier to plug-in a TLS acceptor. See #2479

@davidpdrsn davidpdrsn closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants