Add OptionalQuery extractor #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
reviewed
Nov 13, 2023
auto-merge was automatically disabled
November 14, 2023 11:57
Head branch was pushed to by a user without write access
|
@davidpdrsn, made clippy happy again, take a look, please |
|
Oh no, clippy is mad at axum-core now on 1.75.0-beta.1 |
|
I'll take a look later today! But you're also free to submit a separate PR to fix it. |
davidpdrsn
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #2309
Solution
from_request_partsdoes an additional check if query parameters are supplied. If none are present theOptionalQuery(None)is returned, otherwise it falls back to logic identical toaxum_extra::extract::Query.