Prepare serve
for potentially supporting graceful shutdown
#2357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that graceful shutdown is probably the most common thing missing from
axum::serve
and its not exactly easy with the current state of hyper-util (see #2355).So I could probably convinced to add graceful shutdown support to
serve
😅 I think a good API for that would beDoing that requires returning some type we control from
serve
but we can useIntoFuture
so you can still doserve(...).await
.This needs to go in before shipping 0.7 since its a breaking change.