docs: Remove manual tables of content #2921
Merged
+3
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
jplatte/rm-manual-tocs
branch
from
fc2b7b0
to
e5de4a0
Compare
yanns
approved these changes
Sep 26, 2024
jplatte
force-pushed
the
jplatte/rm-manual-tocs
branch
from
e5de4a0
to
936a6ef
Compare
mladedav
approved these changes
Sep 27, 2024
Comment on lines
+11
to
+12
| - **change**: Remove manual tables of content from the documentation, since | ||
| rustdoc now generates tables of content in the sidebar ([#2921]) |
There was a problem hiding this comment.
Do we want this in the changelog? If users upgrading to a new version is the intended audience, I'm not sure this is something they need to know.
Otherwise I don't know who the intended audience is or if we want all, even infrastructure changes, to be in the changelog.
There was a problem hiding this comment.
Yeah it's not really necessary but I'd like to make a patch release with this and I think empty / no changelogs are not nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs.rs now generates these: