Stricter path deserialization for tuples and tuple structs #2931
+47
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Side note: It appears that the email you have configured git to use as part of your author identity is not one that you told GitHub about, which is why the commits here are not linked to your profile. The squashed commit that will be merged will be associated to your profile though, since GitHub uses the PR author's primary email for this (a gmail address in this case). If that's a problem for you, let me know (even if already merged). |
|
Thanks for the note! I don't mind that it used my primary email, but I will try to add the second email to be associated with my account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2930
Motivation and solution as proposed in that issue.