Fixes TSRs redirecting to toplevel inside nested Router #2993
Conversation
Originally, if you used `route_with_tsr` (let's say `/nyan/`) inside nested route (let's say `/neko`), it got redirected to `/nyan/`, where `/neko/nyan/` was expected. Fixed using `OriginalUri` instead of plain `Uri`.
|
CI failure is not my fault 😭 |
There was a problem hiding this comment.
Looks good to me, we'll take care of the CI.
@jplatte this adds a dependency from axum-extra on axum's original-uri feature which adds one uri clone and adds a request extension to each request. I think that should be fine but wanted to doublecheck with you.
|
Hm, I find that a bit awkward. Maybe we should move |
Well, we are getting Axum 0.8 soon but it's already in alpha and idk if that's a change suited for it? If so i can add it in the fork. |
|
Let's not worry about it in this PR. The way it is now, it can be backported to 0.7. |
Originally, if you used
route_with_tsr(let's say/nyan/) inside nested router (let's say/neko), it got redirected to/nyan/, where/neko/nyan/was expected.Fixed using
OriginalUriinstead of plainUri.