Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakpad doesn't build on v3.x branch #29

Open
timower opened this issue Sep 28, 2023 · 1 comment
Open

breakpad doesn't build on v3.x branch #29

timower opened this issue Sep 28, 2023 · 1 comment

Comments

@timower
Copy link

timower commented Sep 28, 2023

Building the toltec image locally always fails at breakpad with:

150.9 Updating src/default.xml due to changed src/DEPS
150.9 Running: gclient root
150.9 Running: gclient config --spec 'solutions = [
150.9   {
150.9     "name": "src",
150.9     "url": "https://chromium.googlesource.com/breakpad/breakpad.git",
150.9     "managed": False,
150.9     "custom_deps": {},
150.9   },
150.9 ]
150.9 '
150.9 Running: gclient sync
150.9 Running: git submodule foreach 'git config -f $toplevel/.git/config submodule.$name.ignore all'
150.9 Running: git config --add remote.origin.fetch '+refs/tags/*:refs/tags/*'
150.9 Running: git config diff.ignoreSubmodules dirty
151.0 error: Your local changes to the following files would be overwritten by checkout:
151.0   default.xml
151.0 Please commit your changes or stash them before you switch branches.
151.0 Aborting

Seems like some dependency wasn't pinned correctly?

@chriscohoat
Copy link

I've been running into this as well. I've got a fork I'm working on:

v3.x...chriscohoat:toltec-toolchain:bumping-rust-2024-03-23#diff-b093d34eec92adf6e0cc6e445edb7147ea45d25fb0c98f2f84a60f5aae6f34f7R208

And the closest I've gotten so far is by:

  • Upgrading the toolchain Dockerfile from FROM debian:unstable-20230703-slim to FROM debian:unstable-20240311-slim
  • Replacing git checkout db1cda26539c711c3da7ed4d410dfe8190e89b8f with git checkout v2023.06.01 for breakpad: https://github.com/google/breakpad/releases/tag/v2023.06.01
  • Removing the Python2 references as I'm not sure if they are needed with this breakpad version

I was getting some zlib and zlib1g-dev header issues before upgrading the debian version, which seem to be ok now.

The Dockerfiles seem to build now I just need to confirm that my toltec project can also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants