Use Feature Detection instead of Browser Sniffing #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the previous implementation used feature detection, it was using it wrong. It was, essentially using feature detection as a more advanced browser sniffer. * Updated this to detect the features actually being used to measure zoom. * Moved the functions to the same place as the checks, to make it easier to keep the 2 connected. * Made some adjustments so it passes jshint.
|
This unfortunately doesn't work within iframes. |
|
Ah, that's not cool... Not really a use case for us. Did the original work with iframes? If you have any suggestions (or better yet, code), let me know and I'll see if I can make it work... |
|
Never tried the original. Seems to be a couple of years out date. Lack of iframe support shouldn't prevent you from merging though - this PR is still very useful! I'll look into adding support for iframes. |
|
any updates on this? |
|
@ericsaboia Nope... Sorry. I'm no longer using it, so have little reason to get it working for iframes. If you fix it and submit a pull request to my fork, I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the previous implementation used feature detection, it was using
it wrong. It was, essentially using feature detection as a more advanced
browser sniffer.
zoom.
easier to keep the 2 connected.