Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on jsincss unlisted #2

Open
brandonkal opened this issue Jul 12, 2019 · 2 comments
Open

Dependency on jsincss unlisted #2

brandonkal opened this issue Jul 12, 2019 · 2 comments

Comments

@brandonkal
Copy link

This package uses https://unpkg.com/jsincss/index.vanilla.js, but does not specify it as a dependency or a peer dependency

Ref: https://bundlephobia.com/result?p=deqaf

@tomhodgins
Copy link
Owner

Hi @brandonkal I'd love to list this if there's a best practice way of doing this - since it's an ES module consuming an ES module it's not something that shows up under the 'dependencies' tab on npm's website either. What's the right way to go about listing this as a dependency?

@brandonkal
Copy link
Author

Yes. I am not sure exactly what the correct approach here would be.
From reading the spec, it looks like this would work: using the url as the package name and the github location as the version.

{"dependencies": {
  "https://unpkg.com/jsincss/index.vanilla.js": "tomhodgins/jsincss"
  }
}

Though that looks very odd! It seems package.json wasn't designed with external url dependencies in mind...

This really isn't a huge issue though as if you were looking to build an offline app, you probably would use your qaffeine library as a build step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants