Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reduceron to build and follow best practices for GHC/Cabal/Stack #40

Closed
tommythorn opened this issue Aug 19, 2023 · 18 comments · Fixed by #42 · May be fixed by #43
Closed

Update Reduceron to build and follow best practices for GHC/Cabal/Stack #40

tommythorn opened this issue Aug 19, 2023 · 18 comments · Fixed by #42 · May be fixed by #43

Comments

@tommythorn
Copy link
Owner

tommythorn commented Aug 19, 2023

As touched upon in #36, Reduceron doesn't build anymore due to changes to the GHC/Cabal/Stack. Part of the problem is that Flite is effectively a separate project, but a mandatory requirement for Reduceron.

I don't have the expertise to resolve this, but it seems worthwhile to get it back to building, so as an experiment, I'm trying to provide an Algora bounty for this. To make the requirement as clear as possible:

  • Restore the ability to build everything and run all the regressions with a toplevel make
  • Apply the current best practices for Haskell/GHC projects (sounds like using "stack" is a popular approach).

The workaround applied for #36 does not work for me.

/bounty $150

EDIT: typos

@algora-pbc
Copy link

algora-pbc bot commented Aug 19, 2023

💎 $300 bounty • Tommy Thorn

Steps to solve:

  1. Start working: Comment /attempt #40 with your implementation plan
  2. Submit work: Create a pull request including /claim #40 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tommythorn/Reduceron!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @rishi-raj-jain Aug 23, 2023, 1:07:23 PM WIP
🟢 @rodfer0x80 Dec 12, 2023, 12:29:05 AM WIP
🟢 @Neptune650 #42
🟢 @Yashashwini2003 #43

@rishi-raj-jain
Copy link

rishi-raj-jain commented Aug 23, 2023

/attempt #40

Options

1 similar comment
@rodfer0x80
Copy link

rodfer0x80 commented Dec 12, 2023

/attempt #40

Options

@ashish111333
Copy link

is this still open ? @tommythorn

@tommythorn
Copy link
Owner Author

tommythorn commented Dec 4, 2024 via email

@tommythorn
Copy link
Owner Author

tommythorn commented Dec 8, 2024

Let's raise the stakes

/bounty $300

Copy link

algora-pbc bot commented Dec 9, 2024

💡 @Neptune650 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@tommythorn
Copy link
Owner Author

tommythorn commented Dec 9, 2024

After years of nothing, I now have two fixes for this within 24 hours. I'm not sure how to resolve this, but technically @Neptune650 was earlier.

@Neptune650
Copy link
Contributor

Neptune650 commented Dec 9, 2024

After years of nothing, I now have two fixes for this within 24 hours. I'm not sure how to resolve this, but technically @Neptune650 was earlier.

@tommythorn I'd appreciate if you merge mine, as the other pull request was created after mine, does roughly the same changes and the commits were only created after mine.

Also, mine adds GitHub Actions CI which might be a nice bonus.

@tommythorn
Copy link
Owner Author

tommythorn commented Dec 9, 2024

Thanks for your change. You also used the /claim #40 so I think there's not much debate. I'm still evaluating this and hope to accept your change shortly.

@Neptune650
Copy link
Contributor

Thanks for your change. You also used the /claim #40 so I think there's not much debate. I'm still evaluating this and hope to accept your change shortly.

@tommythorn Much appreciated! Let me know if you find any issues.

@tommythorn
Copy link
Owner Author

I'm a bit confused about how this is supposed to be set up. I installed Stack with curl -sSL https://get.haskellstack.org/ | sh and assumed the correctly to install ghc was stack install ghc but after than make still doesn't find runhaskell. Having CI is great, but I think I might need a hint for setting this up for manual use on Ubuntu (and macOS would be nice too).

@Neptune650
Copy link
Contributor

Neptune650 commented Dec 9, 2024

I'm a bit confused about how this is supposed to be set up. I installed Stack with curl -sSL https://get.haskellstack.org/ | sh and assumed the correctly to install ghc was stack install ghc but after than make still doesn't find runhaskell. Having CI is great, but I think I might need a hint for setting this up for manual use on Ubuntu (and macOS would be nice too).

@tommythorn I believe you have to use stack setup instead.

If that doesn't work, try what I did for testing locally and use GHCUp with:
curl --proto '=https' --tlsv1.2 -sSf https://get-ghcup.haskell.org | sh
Then set it up with ghcup tui

Copy link

algora-pbc bot commented Dec 9, 2024

💡 @Yashashwini2003 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@Neptune650
Copy link
Contributor

@tommythorn Thanks for merging, could you award it?

@tommythorn
Copy link
Owner Author

Of course I'm just trying to figure out how (I'll have to ran the door so it will be later today)

@Neptune650
Copy link
Contributor

Of course I'm just trying to figure out how (I'll have to ran the door so it will be later today)

@tommythorn No worries!! You can send it from the Algora bounty panel.

Copy link

algora-pbc bot commented Dec 9, 2024

🎉🎈 @Neptune650 has been awarded $300! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants