fix: safer max text length for sign custom data

ton-blockchain · Feb 23, 2024 · a610433 · a610433
1 parent 4d83e6a
commit a610433
Show file tree

Hide file tree

Showing 29 changed files with 4 additions and 4 deletions.
diff --git a/doc/CUSTOM_DATA.md b/doc/CUSTOM_DATA.md
@@ -30,7 +30,7 @@ text#_ {n:#} data:(SnakeData ~n) = Text;
 Ledger request format:
 | Value | Length or type | Description |
 | --- | --- | --- |
-| `message` | 0-250 | ASCII-only message |
+| `message` | 0-120 | ASCII-only message |
 
 ## App data (0x54b58535)
 

diff --git a/src/sign_data/sign_data_deserialize.c b/src/sign_data/sign_data_deserialize.c
@@ -13,7 +13,7 @@
 
 #define PLAINTEXT_REQUEST          0x754bf91b
 #define APP_DATA_REQUEST           0x54b58535
-#define MAX_PLAINTEXT_LENGTH       188
+#define MAX_PLAINTEXT_LENGTH       120
 #define MAX_APP_DATA_DOMAIN_LENGTH 126  // max allowed domain len as per TON DNS spec
 
 #define SAFE(RES)     \

diff --git a/tests/requirements.txt b/tests/requirements.txt
@@ -1,5 +1,5 @@
 pytest
-ragger[speculos,ledgerwallet]>=1.14.2
+ragger[speculos,ledgerwallet]>=1.14.4
 pysha3>=1.0.0,<2.0.0
 tonsdk==1.0.13
 ecdsa>=0.18.0

diff --git a/tests/snapshots/nanos/test_sign_data/part0/00001.png b/tests/snapshots/nanos/test_sign_data/part0/00001.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00002.png b/tests/snapshots/nanos/test_sign_data/part0/00002.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00003.png b/tests/snapshots/nanos/test_sign_data/part0/00003.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00004.png b/tests/snapshots/nanos/test_sign_data/part0/00004.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00005.png b/tests/snapshots/nanos/test_sign_data/part0/00005.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00006.png b/tests/snapshots/nanos/test_sign_data/part0/00006.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00007.png b/tests/snapshots/nanos/test_sign_data/part0/00007.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00008.png b/tests/snapshots/nanos/test_sign_data/part0/00008.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00009.png b/tests/snapshots/nanos/test_sign_data/part0/00009.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00010.png b/tests/snapshots/nanos/test_sign_data/part0/00010.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00011.png b/tests/snapshots/nanos/test_sign_data/part0/00011.png
diff --git a/tests/snapshots/nanos/test_sign_data/part0/00012.png b/tests/snapshots/nanos/test_sign_data/part0/00012.png
diff --git a/tests/snapshots/nanosp/test_sign_data/part0/00001.png b/tests/snapshots/nanosp/test_sign_data/part0/00001.png
diff --git a/tests/snapshots/nanosp/test_sign_data/part0/00002.png b/tests/snapshots/nanosp/test_sign_data/part0/00002.png
diff --git a/tests/snapshots/nanosp/test_sign_data/part0/00003.png b/tests/snapshots/nanosp/test_sign_data/part0/00003.png
diff --git a/tests/snapshots/nanosp/test_sign_data/part0/00004.png b/tests/snapshots/nanosp/test_sign_data/part0/00004.png
diff --git a/tests/snapshots/nanosp/test_sign_data/part0/00005.png b/tests/snapshots/nanosp/test_sign_data/part0/00005.png
diff --git a/tests/snapshots/nanosp/test_sign_data/part0/00006.png b/tests/snapshots/nanosp/test_sign_data/part0/00006.png
diff --git a/tests/snapshots/nanox/test_sign_data/part0/00001.png b/tests/snapshots/nanox/test_sign_data/part0/00001.png
diff --git a/tests/snapshots/nanox/test_sign_data/part0/00002.png b/tests/snapshots/nanox/test_sign_data/part0/00002.png
diff --git a/tests/snapshots/nanox/test_sign_data/part0/00003.png b/tests/snapshots/nanox/test_sign_data/part0/00003.png
diff --git a/tests/snapshots/nanox/test_sign_data/part0/00004.png b/tests/snapshots/nanox/test_sign_data/part0/00004.png
diff --git a/tests/snapshots/nanox/test_sign_data/part0/00005.png b/tests/snapshots/nanox/test_sign_data/part0/00005.png
diff --git a/tests/snapshots/nanox/test_sign_data/part0/00006.png b/tests/snapshots/nanox/test_sign_data/part0/00006.png
diff --git a/tests/snapshots/stax/test_sign_data/part0/00001.png b/tests/snapshots/stax/test_sign_data/part0/00001.png
diff --git a/tests/test_sign_custom_data.py b/tests/test_sign_custom_data.py
@@ -21,7 +21,7 @@ def test_sign_data(firmware, backend, navigator, test_name):
     pubkey = client.get_public_key(path=path).data
 
     requests: List[SignDataRequest] = [
-        PlaintextSignDataRequest("a" * 188),
+        PlaintextSignDataRequest("a" * 120),
         AppDataSignDataRequest(Cell(), address=Address("0:" + "0" * 64), domain="test.ton", ext=Cell())
     ]