Some significant fixes for ffmpeg-php #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatabile and added a config.w32 for normal windows extension builds. 2. Fixed 2 very significant memory leaks during video decoding. 3. Fixed serious frame decode issue for B frames where random end of video frames would get skipped (at least in current ffmpeg implementations see mpenkov/ffmpeg-tutorial#7 and thanks to sobotka for help). 4. Tried to fix fps and frame count calcuations though don't know if they work across codecs.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been trying to fix some fairly serious issues in this library for a while. It began with a significant decoding memory leak that we found (basically leaked an avframe for each decoded frame), which then led to discovery of another leak, and then further issues with random results on different machines and incorrect pts calculations. Also, we use this library from windows so I updated it to be C89 backwards compatible (since MSVC9 is not C99 compatible) and added a config.w32 for standard php extension compilation on windows. For the random results issue you can reference the following issue: mpenkov/ffmpeg-tutorial#7
These are significant fixes for anyone who might use the library to do anything mildly serious. I haven't tested on linux or OSX but it should compile. On windows, I have been testing with ffmpeg-1.2. Lastly, we have seen what appear to be threading issues with this library, so it should be used with non-thread safe versions of PHP.
Best,
Marc