DuckLeasing performance improvements and bump to 0.4.0 version

tonyredondo · Jun 23, 2020 · b19b389 · b19b389
1 parent b7c5c84
commit b19b389
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/src/Wanhjor.ObjectInspector/DuckTypeLeasing.cs b/src/Wanhjor.ObjectInspector/DuckTypeLeasing.cs
@@ -1,4 +1,5 @@
 using System.Collections.Concurrent;
+using System.Threading;
 
 namespace Wanhjor.ObjectInspector
 {
@@ -9,6 +10,7 @@ namespace Wanhjor.ObjectInspector
     public ref struct DuckTypeLeasing<TInterface> where TInterface:class
     {
         private static readonly ConcurrentStack<TInterface> Proxies = new ConcurrentStack<TInterface>();
+        private static TInterface? _firstItem;
 
         /// <summary>
         /// Current duck type instance
@@ -24,12 +26,20 @@ public void Dispose()
             var inst = Instance;
             Instance = default!;
             ((ISettableDuckType) inst).SetInstance(null!);
+            if (_firstItem == null)
+            {
+                _firstItem = inst;
+                return;
+            }
             Proxies.Push(inst);
         }
 
         internal static DuckTypeLeasing<TInterface> Rent(IDuckTypeFactory<TInterface> factory, object instance)
         {
-            if (!Proxies.TryPop(out var proxy))
+            var proxy = _firstItem;
+            if (proxy != null && proxy == Interlocked.CompareExchange(ref _firstItem, null, proxy))
+                ((ISettableDuckType)proxy).SetInstance(instance);
+            else if (!Proxies.TryPop(out proxy))
                 proxy = factory.Create(instance);
             else
                 ((ISettableDuckType)proxy).SetInstance(instance);
@@ -40,7 +50,17 @@ internal static DuckTypeLeasing<TInterface> Rent(IDuckTypeFactory<TInterface> fa
         }
         internal static DuckTypeLeasing<IDuckType> RentDuckType(IDuckTypeFactory factory, object instance)
         {
-            if (!(Proxies.TryPop(out var proxy) && proxy is ISettableDuckType dtProxy))
+            var proxy = _firstItem;
+            if (proxy != null && proxy == Interlocked.CompareExchange(ref _firstItem, null, proxy) && proxy is ISettableDuckType sProxy)
+            {
+                sProxy.SetInstance(instance);
+                return new DuckTypeLeasing<IDuckType>
+                {
+                    Instance = sProxy
+                };
+            }
+
+            if (!(Proxies.TryPop(out proxy) && proxy is ISettableDuckType dtProxy))
                 dtProxy = (ISettableDuckType) factory.Create(instance);
             else
                 dtProxy.SetInstance(instance);

diff --git a/src/Wanhjor.ObjectInspector/Wanhjor.ObjectInspector.csproj b/src/Wanhjor.ObjectInspector/Wanhjor.ObjectInspector.csproj
@@ -6,7 +6,7 @@
     <Description>An efficient .NET object inspector/accesor to avoid reflection usage with duck typing support.</Description>
     <LangVersion>8</LangVersion>
     <Nullable>enable</Nullable>
-    <Version>0.4.0-beta.9</Version>
+    <Version>0.4.0</Version>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Title>ObjectInspector</Title>
     <Authors>Daniel Redondo</Authors>