-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client should now respect the maxBatchSize setting from the server #94
Conversation
Also added to log output how many requests used Bytestream vs CAS
Will add @tdyas as a reviewer once he accepts the invite (he may be interested in toolchain's IP more generally) |
Thanks @Faqa - review pending. Please ping here if we don't get back to you in a few days. |
@benjyw - Pinging as requested (The build failure doesn't seem to be anything under my control?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'll defer to @tdyas for a quick look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
@Faqa - can you merge latest main into this branch? I fixed some CI bitrot there, so that should get this PR to pass CI. Thanks! |
@Faqa actually - wait until I fix the publishing CI job too... I'll ping here when it's good. |
@Faqa - OK, CI is fixed, so if you merge latest main onto your branch your CI should pass, and we can merge. Thanks for your patience! |
Use scie-pants, and update CI to recent actions versions.
Merged, thanks again @Faqa |
Also added to log output how many requests used Bytestream vs CAS