Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete stale renditions when file or focal area changes are detected #24

Merged

Conversation

ababic
Copy link
Collaborator

@ababic ababic commented Apr 24, 2024

This is typically handled by wagtail.images.forms.BaseImageForm when updating images via the UI, but there's currently nothing in place to handle this when updating model instances directly.

@ababic
Copy link
Collaborator Author

ababic commented Apr 24, 2024

@zerolab I was seeing similar pre-commit job failures on previous PRs when the ruff job was passing. I can only assume they are using different versions or configurations of ruff?

@ababic ababic changed the base branch from main to fix/force-download-option-causes-typerror April 24, 2024 11:25
@ababic ababic force-pushed the fix/force-download-option-causes-typerror branch from afb5119 to 8b56d31 Compare April 24, 2024 20:56
@ababic ababic force-pushed the feature/delete-renditions-when-file-or-focal-area-changes branch from d472b8e to f29855d Compare April 24, 2024 20:58
@ababic ababic changed the base branch from fix/force-download-option-causes-typerror to main April 24, 2024 20:58
@ababic
Copy link
Collaborator Author

ababic commented Apr 24, 2024

pre-commit.ci autofix

@ababic ababic merged commit 8facc2d into main Apr 24, 2024
6 checks passed
@ababic ababic deleted the feature/delete-renditions-when-file-or-focal-area-changes branch April 24, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants