Improve conversion of focus points into focal areas #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions to a maximum of 40% of the total image width or height
zerolab
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current conversion behaviour is too conservative. When the 1D focus point in Bynder is set close to the centre of the image, the rectangular 'focal area' generated for Wagtail is created by drawing a rectangle around that point that spreads outwards until it can't be any wider or taller.
This isn't really helpful, and actually leads to Wagtail creating some strange crops (as it tries to preserve everything)!
In a bid to improve this on a current project, I came up with this new approach, which instead draws a width-restricted (to 40% of the image) square around the focus point, which produces 'tighter' crops without losing too much of the image.