Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tag widget in popup chooser #214

Closed
harrislapiroff opened this issue Jul 12, 2023 · 1 comment · Fixed by #216
Closed

Use tag widget in popup chooser #214

harrislapiroff opened this issue Jul 12, 2023 · 1 comment · Fixed by #216

Comments

@harrislapiroff
Copy link

Issue Summary

The media upload form in the media section of the admin has an autocompleting tokenizing tag widget but the form in the popup has a plain text field:

In popup:
image

In media section of admin:
image

This can produce some user confusion: we had an admin complain that when they pressed "enter" to confirm a tag, it submitted the form instead and as you can see above, I wasn't sure whether tags should be space-separated or comma-separated in the popup. (In retrospect the help text does say to use quotes, but it's not the clearest help text I've seen and better would be to unify the two interfaces).

Steps to Reproduce

  1. Edit a page that uses MediaChooserBlock
  2. Add a media block and click "choose media item"
  3. Choose "Upload video" (interestingly the behavior is fine for "Upload audio")
  4. Try to enter multiple tags using [tag name] + enter button

Expected behavior is that it would complete the tag token and allow me to enter another tag. Actual behavior is that it submits the form.

Technical details

  • Python version: 3.9.16
  • Django version: 3.2.20
  • Wagtail version: 4.1.4
  • wagtailmedia version: 0.14.2
  • Browser version: Firefox 115 macOS 10.15
@zerolab zerolab linked a pull request Jul 19, 2023 that will close this issue
@zerolab
Copy link
Member

zerolab commented Jul 19, 2023

Hey @harrislapiroff, this should be fixed in v0.14.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants