Updated insert_editor_css to insert_global_admin_css
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
approved these changes
Aug 1, 2023
| @@ -109,7 +109,7 @@ class MediaAdminURLFinder(ModelAdminURLFinder): | |||
| register_admin_url_finder(get_media_model(), MediaAdminURLFinder) | |||
|
|
|||
|
|
|||
| @hooks.register("insert_editor_css") | |||
| @hooks.register("insert_global_admin_css") | |||
There was a problem hiding this comment.
while I would've preferred a single hook implementation, this is good enough.
Note to self: got to do more clean up, and potentially drop this CSS file entirely -
https://github.com/torchbox/wagtailmedia/blob/main/src/wagtailmedia/static/wagtailmedia/css/wagtailmedia.css#L5-L13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was made to satisfy the issue: #217
Updated the
wagtail_hooksthat contains a hook usinginsert_editor_csswhich is bringing in aRemovedInWagtail60Warningwhen upgrading towagtail5.1.Changing this to use
insert_global_admin_csswill resolve the deprecation warning.