Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change classnames -> classname in wagtail_hooks.py #225

Closed
wants to merge 1 commit into from

Conversation

jamesbiggs
Copy link
Contributor

This PR was made to satisfy the issue: #224

Updated the wagtail_hooks.py that contains a hook using the classnames attribute which is bringing in a RemovedInWagtail60Warning when upgrading to wagtail 5.2.

Changing this to use classname will resolve the deprecation warning.

@jamesbiggs
Copy link
Contributor Author

Hey @zerolab, I thought this'd be another easy one - but not sure why the CI is failing? Is it because it's not compatible with earlier versions or something?

@zerolab
Copy link
Member

zerolab commented Nov 1, 2023

@jamesbiggs there was a typo in one of the tests in main 🙈

At the same time, classname only came in effect in 4.2, so this would be broken for 4.1

I've switched to using icon_name like everywhere else in Wagtail. And kept your commit. Thank you

@zerolab zerolab closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants