Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix clippy and rust problems #47

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

da2ce7
Copy link

@da2ce7 da2ce7 commented Jul 16, 2024

Fix Clippy Warnings for entire Project and Update Testing Workflow.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 44.84536% with 214 lines in your changes missing coverage. Please review.

Project coverage is 59.72%. Comparing base (6b7bcc9) to head (ee84bfc).

Files Patch % Lines
packages/select/src/discovery/ut_metadata.rs 0.00% 46 Missing ⚠️
packages/dht/src/worker/handler.rs 0.00% 18 Missing ⚠️
packages/peer/src/message/standard.rs 5.55% 17 Missing ⚠️
examples/simple_torrent/src/main.rs 0.00% 15 Missing ⚠️
examples/get_metadata/src/main.rs 0.00% 14 Missing ⚠️
packages/dht/src/worker/lookup.rs 0.00% 12 Missing ⚠️
packages/select/src/revelation/honest.rs 67.85% 9 Missing ⚠️
packages/peer/src/message/prot_ext/mod.rs 0.00% 7 Missing ⚠️
packages/dht/src/worker/bootstrap.rs 0.00% 5 Missing ⚠️
packages/dht/src/worker/messenger.rs 0.00% 5 Missing ⚠️
... and 27 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #47      +/-   ##
===========================================
+ Coverage    59.42%   59.72%   +0.29%     
===========================================
  Files          135      135              
  Lines        11385    11342      -43     
===========================================
+ Hits          6766     6774       +8     
+ Misses        4619     4568      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@da2ce7 da2ce7 force-pushed the 20240716_rust_update branch 7 times, most recently from a98a2cc to 05e9c1f Compare July 16, 2024 21:19
@da2ce7 da2ce7 force-pushed the 20240716_rust_update branch from 05e9c1f to ee84bfc Compare July 16, 2024 21:25
@da2ce7
Copy link
Author

da2ce7 commented Jul 16, 2024

ACK ee84bfc

@da2ce7 da2ce7 merged commit f3c71f8 into torrust:develop Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants