Fixing Windows compiling #1098
Closed
Fixing Windows compiling #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1098 +/- ##
========================================
Coverage 76.25% 76.25%
========================================
Files 174 174
Lines 11377 11377
Branches 11377 11377
========================================
+ Hits 8675 8676 +1
Misses 2503 2503
+ Partials 199 198 -1 ☔ View full report in Codecov by Sentry. |
|
ACK 39d0b76 |
|
Thank you @Power2All !!! |
This was referenced Nov 22, 2024
|
Hi @Power2All I've open a new PR only to sign the commit: #1108. We have set repo rules to only allow signed commits. |
Fine with me, only tried to fix the compile issue ;) |
josecelano
added a commit
that referenced
this pull request
Nov 27, 2024
66a8648 fix: [#325] windows compiling (Power2All) Pull request description: This PR supersedes this #1098 only to sign the commit. ACKs for top commit: josecelano: ACK 66a8648 Tree-SHA512: 1c216a8a270f73f773f6108355be5a5eeb957d186f6d7154f0ee60380334687e3f3c5fa764e9f60ee7df415aea84e4d36ec157015db3a0000689a1a53f555d25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing compiling in Windows, was simple.
Now you don't need cmake or any of that.