Log assertions: add assertions for log errors in HTTP tracker #1163
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's using the info-hash to find the ERROR in logs. IT's generated a newly random info-hash for each tests. It could have been also used a `x-request-id` header in the HTTP request but this solution is simpler and the chances to have an info-hash collision is very low.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1163 +/- ##
========================================
Coverage 76.17% 76.17%
========================================
Files 174 174
Lines 11601 11601
Branches 11601 11601
========================================
Hits 8837 8837
Misses 2606 2606
Partials 158 158 ☔ View full report in Codecov by Sentry. |
josecelano
changed the title
|
ACK 03243cb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log assertions: add assertions for log errors in HTTP tracker.
It's using the info-hash to find the ERROR in logs. It's generated a newly random info-hash for each test.
It could have been also used a
x-request-idheader in the HTTP request but this solution is simpler and the chances to have an info-hash collision is very low.