Extract new package: Tracker API client #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
force-pushed
the
1159-extract-tracker-tracker-api-client-workspace-package
branch
from
09ec5b2 to
a1ded65
Compare
josecelano
added
- Developer -
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1179 +/- ##
===========================================
+ Coverage 76.07% 76.36% +0.28%
===========================================
Files 174 177 +3
Lines 11599 11906 +307
Branches 11599 11906 +307
===========================================
+ Hits 8824 9092 +268
- Misses 2606 2648 +42
+ Partials 169 166 -3 ☔ View full report in Codecov by Sentry. |
The Tracker API client was extracted into a new package. This removes the duplicate client in tests and starts using the new package.
josecelano
force-pushed
the
1159-extract-tracker-tracker-api-client-workspace-package
branch
from
99fcbb6 to
e4b9875
Compare
josecelano
force-pushed
the
1159-extract-tracker-tracker-api-client-workspace-package
branch
from
b6abf2b to
b47cc0a
Compare
Instead of using a plain string we now use a Origin type containing hte base URL for the API without path or fragments. ``` scheme://host:port/ ```
josecelano
force-pushed
the
1159-extract-tracker-tracker-api-client-workspace-package
branch
from
b47cc0a to
aa7ffdf
Compare
|
ACK aa7ffdf |
josecelano
changed the title
josecelano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract new package: Tracker API client.
I've also extracted a new type
Originfor the API base URL in the connection info. For example:htpp://tracker.com:1212/.