Refactor: Move logic to http-protocol and primitives packages
#1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
added
Code Cleanup / Refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1180 +/- ##
===========================================
- Coverage 76.37% 76.22% -0.16%
===========================================
Files 177 178 +1
Lines 11906 11898 -8
Branches 11906 11898 -8
===========================================
- Hits 9093 9069 -24
- Misses 2648 2658 +10
- Partials 165 171 +6 ☔ View full report in Codecov by Sentry. |
josecelano
changed the title
http-protocol packagehttp-protocol and primitives packages
… primitives packages - Generic logic for http tracker has bben moved to http-protocol package (bittorrent-http-protocol crate). - Generic tracker types like AnnounceData and ScrapeData have been moved to the primitives package (torrust-tracker-primitives crate). This has also a desiderable side effect: generic re-usable domain logic has been decoupled from Axum framework.
josecelano
force-pushed
the
1140-extract-more-logic-to-the-http-protocol-package
branch
from
9142063 to
a7ceb0f
Compare
Some doc tests were slow becuase they required to compile the main library. The code used from the main library was moved to workspace pacakages and there is no dependency with the main tracker lib. See torrust#1097
|
ACK c2d134e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Move HTTP tracker logic to
http-protocolpackage and core tracker types toprimitivespackage. This will: