Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: days.ts의 테스트 coverage를 보강합니다 #294

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

po4tion
Copy link
Collaborator

@po4tion po4tion commented Nov 28, 2024

Overview

ASIS.
image

TOBE.
image

ones라는 변수는 첫번째 조건문을 지나면 DAYS_MAP 상수의 키값 중 하나일 수 밖에 없기에 삼항 연산자를 제거하였습니다.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@po4tion po4tion self-assigned this Nov 28, 2024
Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: c54c423

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 10:51am

@po4tion po4tion changed the title chore: days.ts 파일 테스트 coverage를 보강합니다 chore: days.ts의 테스트 coverage를 보강합니다 Nov 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (2e5967c) to head (c54c423).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          38       38           
  Lines         642      642           
  Branches      156      155    -1     
=======================================
  Hits          639      639           
  Misses          3        3           

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다~

@okinawaa okinawaa merged commit a21343f into main Nov 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants