fix: crash when navigate to next vertical #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop to main. Release v1.1
Develop to main. Release v1.2.1
Develop to main. Release v1.2.2
Develop to main. Github workflow.
* bug fix (openedx#57) * Fix DisclosureGroup fields bug on SignUpView (openedx#58) * Hide no discussion while update (openedx#59) * Consolidating Databases and Refactoring Module Logic (openedx#60) This merge request aims to consolidate multiple databases into a single one for improved efficiency and maintainability in the OpenEdx project. The changes involve creating a new class, DatabaseManager, which handles CoreData operations and moving CoreData logic from specific modules to this central manager. Additionally, a new method, deleteAllFiles(), is added to the DownloadManager class for convenient file deletion upon user logout. * Migrate all colors to Theme (openedx#61) * Added support for multiple color schemes to quickly switch between educational platforms. Updated variables throughout the project accordingly. * Fix not updating completion error (openedx#64) completion doesn't update status when user has finished learning the contents of a unit * Remove custom navigation controller (openedx#63) * Remove custom navigation controller Change navigation controller from custom to system for feature changes and adding possibility to swipe gestures * disable routing whenever handouts is empty (openedx#66) * Fix the isMobileData variable in the Connectivity module. (openedx#67) Add the possibility to play videos with sound in silent mode. * encoded video dissmiss by device rotation (openedx#68) * fixed * Separate AppStorage to protocol oriented architecture. (openedx#69) * Separate AppStorage to protocol oriented architecture. * Added path field to the DownloadData model. (openedx#70) * Added path field to the DownloadData model. All control over files was refactored using the new path field. * Fix CourseContainerViewModelTests * September bugfixes (openedx#71) * fix incorrect back button on the course screen * Fix issue on Delete account view. The inactive button is clickable. * change CourseDetailsEndpoint to CourseEndpoint fix WebView bug with iframe fix doubling courses on Dashboard after subscribe to a new course * Create 0001-strategy-for-maintaining-OS-versions.rst (openedx#72) * Create 0001-strategy-for-maintaining-OS-versions.rst * Update 0001-strategy-for-maintaining-OS-versions.rst * Deprecate iOS 14 (openedx#74) * Deprecate iOS 14 Remove isIOS14 in ViewExtension Change deployment target to iOS 15 Add a new RefreshableScrollView for better pull to refresh animation on any iOS update loading logic in DiscoveryViewModel, ThreadViewModel, and PostsViewModel for a smooth refreshing * Update refreshable ScrollView to native for iOS 16+ (openedx#75) * Update refreshable ScrollView to native for iOS 16+ * Codestyle improvements (openedx#76) * codestyle improvements * remove unused code * ios 17 bugfixes (openedx#77) * bugfixes * Change license to Apache (openedx#78) --------- Co-authored-by: IvanStepanok <128456094+IvanStepanok@users.noreply.github.com>
This reverts commit 83ee9bf.
Develop to master v1.3
* build: Creating workflow `self-assign-issue.yml`. The .github/workflows/self-assign-issue.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org. * build: Creating workflow `add-depr-ticket-to-depr-board.yml`. The .github/workflows/add-depr-ticket-to-depr-board.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org. * build: Creating workflow `commitlint.yml`. The .github/workflows/commitlint.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org. * build: Creating workflow `add-remove-label-on-comment.yml`. The .github/workflows/add-remove-label-on-comment.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org.
rnr
approved these changes
Dec 6, 2023
…ook, and Google (openedx#176) * feat: add login with * chore: remove spacing * fix: padding bottom social view * chore: result social * chore: add new struct for credentials * chore: add request social login * chore: add request and change design buttons * chore: add handle MSAL Response * chore: add ocial login enabled feature flag * chore: add configs and flags * chore: rename file * chore: add accessibility, localizable strings uk, and flags for socials * chore: remove extra code * chore: add google config * chore: move enabled google sign in to google config * chore: add new dict social login * chore: remove extra code, change names, add colors * refactor: open URL options key method * refactor: add SocialSignView previews * chore: add apple sign in config, pr issues * chore: improvement sign up with third party auth, new error if third party auth cancelled * chore: add not linked acc error when login by third party auth * chore: add same canceled error * chore: add error if not register by social auth * fix: fix msal lib * chore: login if can when register if social provider and add name email to field after apple sign in * chore: save full name after login with apple * chore: add microsoft to package * chore: changes from PR feedback * chore: changes from PR feedback * chore: add tests * chore: changes from PR feedback * chore: remove extra code * chore: remove extra code and add tests * chore: changes for saving apple info to appstorage * chore: remove extra code and change social auth details * chore: change LoginMethod -> AuthMethod and remove extra code * chore: change names --------- Co-authored-by: Eugene Yatsenko <yyatsenko@2u.com>
* feat: added unit popup menu * chore: a little design changes * feat: added accessibilty * fix: accessiblity fix * chore: remove config paramaters * fix: added flag to hide/show unit dropdown menu * fix: title for video type block * chore: refactor * feat: added feature flag * chore: PR review fixes * fix: merge conflict
eyatsenkoperpetio
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #187